Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Input): update input onChange ts and file #4271

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

weinianyang
Copy link
Contributor

No description provided.

@weinianyang
Copy link
Contributor Author

image

@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.01 ⚠️

Comparison is base (9e69eab) 90.58% compared to head (50161e8) 90.58%.

❗ Current head 50161e8 differs from pull request most recent head 40b641f. Consider uploading reports for the commit 40b641f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4271      +/-   ##
==========================================
- Coverage   90.58%   90.58%   -0.01%     
==========================================
  Files         305      305              
  Lines       17948    17950       +2     
  Branches     5525     5526       +1     
==========================================
+ Hits        16259    16260       +1     
- Misses       1668     1669       +1     
  Partials       21       21              
Impacted Files Coverage Δ
src/overlay/index.jsx 75.00% <50.00%> (-1.20%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -185,7 +185,7 @@ export interface InputProps extends HTMLAttributesWeak, CommonProps {
/**
* 发生改变的时候触发的回调
*/
onChange?: (value: string, e: React.ChangeEvent<HTMLInputElement>) => void;
onChange?: (value: string, e: React.ChangeEvent<HTMLInputElement>, type: string) => void;
Copy link
Contributor

@lakerswgq lakerswgq Mar 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个参数是可选的

@lakerswgq lakerswgq merged commit a73e73a into alibaba-fusion:master Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants